This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
Django execute_code command #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pipe Python code via heredoc to Django shell
| @@ -147,6 +147,8 @@ def settings_module(self): | |||
| def wsgi_app_location(self): | |||
| return '/etc/wsgi-apps/%s.py' % self.slug | |||
|
|
|||
| def execute_code(self, code): | |||
| self.hosts.run(self._get_management_command('shell --plain') + " <<__HEREDOC__\n" + code + "\n__HEREDOC__") | |||
There was a problem hiding this comment.
This depends on magic escape characters and can possibly suffer from injection.
Please refactor to something like this:
self.hosts.run(self._get_management_command('shell --plain'), initial_input = '%s\nimport sys; sys.exit(0)' % code)
That should already work out of the box.
Better would even be, to add a boolean option to Host._run and Host._posix_shell called "send_EOF_after_initial_input"
If True, send Ctrl-D after the initial input.
Then it becomes:
self.hosts.run(self._get_management_command('shell --plain'), initial_input=code, send_EOF_after_initial_input=True)
Not sure about the naming, but that's the idea.
jonathanslenders
force-pushed
the
master
branch
2 times, most recently
from
cf54f50 to
32c1030
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pipe Python code via heredoc to Django shell. Crude, but it works.
--plainalways uses the regular Python instead of IPython, this gives us consistency over all servers.